Skip to content

Bump selenium-standalone to 8.3.0 - allow E2E testing on osx-arm64 #48288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Bump selenium-standalone to 8.3.0 - allow E2E testing on osx-arm64 #48288

wants to merge 3 commits into from

Conversation

lambdageek
Copy link
Member

Bump selenium-standalone to 8.3.0

Description

Fixes #45838

@ghost ghost added the needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically label May 17, 2023
@BrennanConroy
Copy link
Member

Good luck, see previous attempt at this
#44834

@lambdageek

This comment was marked as outdated.

Sign in to view
@lambdageek lambdageek force-pushed the selenium-standalone-bump branch from c673354 to e137230 Compare May 18, 2023 00:44
@lambdageek
Copy link
Member Author

lambdageek commented May 18, 2023 •
edited
Loading

oh, it's failing now because of webdriverio/selenium-standalone#736 that @MackinnonBuck noticed back in November. I wonder if we can specify the java options in some other way

I wonder if selenium-standalone would pass through the JDK_JAVA_OPTIONS environment variable or if it would get sanitized...

Update it's passed through. CI seems to be running the tests now, actually

@lambdageek
Pass CHROMEDRIVER using JDK_JAVA_OPTIONS
bb2505e 
Can't use the selenium-standalone --javaArgs=... option due to a
parsing bug upstream.  Instead use the JDK option
@lambdageek
Copy link
Member Author

It looks like the only other package.json+yarn.lock that mentions selenium-standalone is in src/ProjectTemplates/test/Templates.Tests

I'll try to update it when i'm on a machine where I can do the vsts auth thing

@lambdageek
Copy link
Member Author

well the e2e tests run, but it looks like at some point chrome just crashes and selenium can't restart it. No clue why, yet.

@lambdageek lambdageek mentioned this pull request May 18, 2023
Closed
1 task
@mkArtakMSFT mkArtakMSFT added area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework and removed needs-area-label Used by the dotnet-issue-labeler to label those issues which couldn't be triaged automatically labels May 22, 2023
@ghost
Copy link

ghost commented May 22, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@amcasey
Copy link
Member

amcasey commented Jun 12, 2023

@lambdageek Are you still working on this?

@lambdageek
Copy link
Member Author

@amcasey no, sorry. I gave up.

@lambdageek lambdageek closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails on Mac M1 with "ENOENT: no such file or directory" due to selenium-standalone
4 participants
@lambdageek @BrennanConroy @amcasey @mkArtakMSFT